Skip to content

⚡️ Speed up method CodeFlashBenchmarkPlugin.pytest_collection_modifyitems by 670% in PR #574 (easier-benchmark) #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: pydantic ai benchmarking support
wants to merge 1 commit into from
Closed

⚡️ Speed up method CodeFlashBenchmarkPlugin.pytest_collection_modifyitems by 670% in PR #574 (easier-benchmark) #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions codeflash/benchmarking/plugin/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,16 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
if not config.getoption("--codeflash-trace"):
return

skip_marker = pytest.mark.skip(reason="Test requires benchmark marker")
for item in items:
# Check for @pytest.mark.benchmark marker
if hasattr(item, "get_closest_marker"):
marker = item.get_closest_marker("benchmark")
if marker is None:
item.add_marker(pytest.mark.skip(reason="Test requires benchmark marker"))
get_marker = getattr(item, "get_closest_marker", None)
if get_marker is not None:
if get_marker("benchmark") is None:
item.add_marker(skip_marker)
else:
# If item does not have get_closest_marker (rare), skip it for correctness
continue

# Benchmark fixture
class Benchmark: # noqa: D106
Expand Down
Loading