Skip to content

[Lsp] return diff functions grouped by file #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

[Lsp] return diff functions grouped by file #688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55cb7f4
send the file paths with the functions in the current diff
mohammedahmed18 Aug 25, 2025
90ebac3
revert comment
mohammedahmed18 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions codeflash/lsp/beta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ProvideApiKeyParams:
@server.feature("getOptimizableFunctionsInCurrentDiff")
def get_functions_in_current_git_diff(
server: CodeflashLanguageServer, _params: OptimizableFunctionsParams
) -> dict[str, str | list[str]]:
) -> dict[str, str | dict[str, list[str]]]:
functions = get_functions_within_git_diff(uncommitted_changes=True)
file_to_funcs_to_optimize, _ = filter_functions(
modified_functions=functions,
Expand All @@ -55,8 +55,10 @@ def get_functions_in_current_git_diff(
module_root=server.optimizer.args.module_root,
previous_checkpoint_functions={},
)
qualified_names: list[str] = [func.qualified_name for funcs in file_to_funcs_to_optimize.values() for func in funcs]
return {"functions": qualified_names, "status": "success"}
file_to_qualified_names: dict[str, list[str]] = {
str(path): [f.qualified_name for f in funcs] for path, funcs in file_to_funcs_to_optimize.items()
}
return {"functions": file_to_qualified_names, "status": "success"}


@server.feature("getOptimizableFunctions")
Expand Down
Loading