Skip to content

[LSP] always process args when calling initProject & remove the git validation (extension handles it now) #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

[LSP] always process args when calling initProject & remove the git validation (extension handles it now) #804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d3f0a5
lsp: always process the server args when calling initProject
mohammedahmed18 Oct 9, 2025
cd4f7e2
Merge branch 'main' into lsp/always-process-args-when-calling-initPro…
Saga4 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions codeflash/lsp/beta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from pathlib import Path
from typing import TYPE_CHECKING, Optional

import git
from pygls import uris

from codeflash.api.cfapi import get_codeflash_api_key, get_user_id
Expand Down Expand Up @@ -155,11 +154,13 @@ def _find_pyproject_toml(workspace_path: str) -> tuple[Path | None, bool]:

# should be called the first thing to initialize and validate the project
@server.feature("initProject")
def init_project(server: CodeflashLanguageServer, params: ValidateProjectParams) -> dict[str, str]: # noqa: PLR0911
def init_project(server: CodeflashLanguageServer, params: ValidateProjectParams) -> dict[str, str]:
from codeflash.cli_cmds.cmd_init import is_valid_pyproject_toml

pyproject_toml_path: Path | None = getattr(params, "config_file", None) or getattr(server.args, "config_file", None)
# Always process args in the init project, the extension can call
server.args_processed_before = False

pyproject_toml_path: Path | None = getattr(params, "config_file", None) or getattr(server.args, "config_file", None)
if pyproject_toml_path is not None:
# if there is a config file provided use it
server.prepare_optimizer_arguments(pyproject_toml_path)
Expand Down Expand Up @@ -196,14 +197,6 @@ def init_project(server: CodeflashLanguageServer, params: ValidateProjectParams)
return {"status": "error", "message": "not valid", "pyprojectPath": pyproject_toml_path}

args = process_args(server)
repo = git.Repo(args.module_root, search_parent_directories=True)
Copy link
Contributor

@Saga4 Saga4 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to the VSC extension.

if repo.bare:
return {"status": "error", "message": "Repository is in bare state"}

try:
_ = repo.head.commit
except Exception:
return {"status": "error", "message": "Repository has no commits (unborn HEAD)"}

return {"status": "success", "moduleRoot": args.module_root, "pyprojectPath": pyproject_toml_path, "root": root}

Expand Down
Loading