Skip to content

Conversation

@KRRT7
Copy link
Contributor

@KRRT7 KRRT7 commented Oct 14, 2025

User description

this is preventing latest version of codeflash on a project I'm trying to install it on, it forces the project to resolve to v0.10


PR Type

Enhancement


Description

  • Loosen pytest version constraint

  • Allow installation with latest pytest


Diagram Walkthrough

flowchart LR
  deps["Project dependencies in pyproject.toml"]
  pytest["pytest version constraint"]
  compat["Broader compatibility with environments"]

  deps -- "update constraint" --> pytest
  pytest -- "no exclusion of 8.3.4" --> compat
Loading

File Walkthrough

Relevant files
Dependencies
pyproject.toml
Loosen pytest dependency constraint                                           

pyproject.toml

  • Remove !=8.3.4 exclusion from pytest dependency.
  • Keep minimum version pytest>=7.0.0.
+1/-1     

@github-actions
Copy link

github-actions bot commented Oct 14, 2025

PR Reviewer Guide 🔍

(Review updated until commit 234df4b)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Compatibility Check

Verify that the project’s test suite and plugins are compatible with pytest 8.3.4 and newer, as removing the exclusion may surface previously masked incompatibilities.

"unidiff>=0.7.4",
"pytest>=7.0.0",
"gitpython>=3.1.31",
Dependency Resolution

Confirm that loosening pytest does not introduce conflicts with other dev/test dependencies (e.g., pytest plugins) in the environment or lockfile generation.

"unidiff>=0.7.4",
"pytest>=7.0.0",
"gitpython>=3.1.31",

@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@KRRT7 KRRT7 marked this pull request as ready for review October 14, 2025 01:18
@KRRT7
Copy link
Contributor Author

KRRT7 commented Oct 14, 2025

I think we had pinned it due to formatting differences in py 3.13 but that was resolved in a diff pr by @misrasaurabh1

@KRRT7 KRRT7 requested a review from a team October 14, 2025 01:18
@github-actions
Copy link

Persistent review updated to latest commit 234df4b

@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@KRRT7 KRRT7 enabled auto-merge October 14, 2025 04:25
@KRRT7 KRRT7 merged commit a50e0c4 into main Oct 14, 2025
20 of 21 checks passed
@KRRT7 KRRT7 deleted the loosen-requirements branch October 14, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants