-
Notifications
You must be signed in to change notification settings - Fork 22
Add Optimization Review Label in VSC Extension #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍(Review updated until commit ac50ae2)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to ac50ae2
Previous suggestionsSuggestions up to commit f32a11d
|
|
Persistent review updated to latest commit ac50ae2 |
| self.executor = concurrent.futures.ThreadPoolExecutor( | ||
| max_workers=n_tests + 3 if self.experiment_id is None else n_tests + 4 | ||
| ) | ||
| self.optimization_review = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we including optimization review lavel to e2e tests?
Saga4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we can add review label to e2e tests.
|
waiting for backend changes to be deployed first before we merge this one |
|
Codeflash Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR Type
Enhancement, Bug fix
Description
Always generate optimization review response
Expose review in perform optimization result
Initialize optimizer review storage
Maintain PR creation logic and safety
Diagram Walkthrough
File Walkthrough
perform_optimization.py
Return optimization review via LSP responsecodeflash/lsp/features/perform_optimization.py
optimization_reviewin success payload.function_optimizer.py
Unconditionally generate and store optimization reviewcodeflash/optimization/function_optimizer.py
self.optimization_reviewfield.data.