Skip to content

submodule bugs #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2025
Merged

submodule bugs #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d285b9
submodule bugs
Nov 15, 2025
036d6f6
submodule bugs
Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion codeflash/discovery/functions_to_optimize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,10 @@ def is_git_repo(file_path: str) -> bool:
def ignored_submodule_paths(module_root: str) -> list[str]:
if is_git_repo(module_root):
git_repo = git.Repo(module_root, search_parent_directories=True)
return [Path(git_repo.working_tree_dir, submodule.path).resolve() for submodule in git_repo.submodules]
try:
return [Path(git_repo.working_tree_dir, submodule.path).resolve() for submodule in git_repo.submodules]
except Exception as e:
logger.warning(f"Error getting submodule paths: {e}")
return []


Expand Down
5 changes: 4 additions & 1 deletion codeflash/tracing/tracing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ def ignored_submodule_paths(module_root: str) -> list[Path]:
if is_git_repo(module_root):
git_repo = git.Repo(module_root, search_parent_directories=True)
working_tree_dir = cast("Path", git_repo.working_tree_dir)
return [Path(working_tree_dir, submodule.path).resolve() for submodule in git_repo.submodules]
try:
return [Path(working_tree_dir, submodule.path).resolve() for submodule in git_repo.submodules]
except Exception as e:
print(f"Failed to get submodule paths {e!s}") # no logger since used in the tracer
return []


Expand Down
Loading