Skip to content

[LSP][FIX] prefill the existing config values from the client #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2025
Merged

[LSP][FIX] prefill the existing config values from the client #926

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9edbf27
move the config default values to the client
mohammedahmed18 Nov 17, 2025
8a0a866
Merge branch 'main' into lsp/move-config-suggestion-default-values-to…
aseembits93 Nov 17, 2025
283524d
Merge branch 'main' into lsp/move-config-suggestion-default-values-to…
mohammedahmed18 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 11 additions & 31 deletions codeflash/lsp/beta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,37 +235,11 @@ def get_config_suggestions(_params: any) -> dict[str, any]:
tests_root_suggestions.append(".")
default_tests_root = tests_root_suggestions[0] if tests_root_suggestions else "."

try:
configured_module_root = (
Path(server.args.module_root).relative_to(Path.cwd()) if server.args.module_root else None
)
except: # noqa : E722
configured_module_root = None
try:
configured_tests_root = Path(server.args.tests_root).relative_to(Path.cwd()) if server.args.tests_root else None
except: # noqa : E722
configured_tests_root = None
try:
configured_test_framework = server.args.test_framework if server.args.test_framework else None
except: # noqa : E722
configured_test_framework = None
configured_formatter = ""
try:
if isinstance(server.args.formatter_cmds, list):
configured_formatter = " && ".join([cmd.strip() for cmd in server.args.formatter_cmds])
elif isinstance(server.args.formatter_cmds, str):
configured_formatter = server.args.formatter_cmds.strip()
except: # noqa : E722
configured_formatter = "disabled"

return {
"module_root": {"choices": module_root_suggestions, "default": configured_module_root or default_module_root},
"tests_root": {"choices": tests_root_suggestions, "default": configured_tests_root or default_tests_root},
"test_framework": {
"choices": test_framework_suggestions,
"default": configured_test_framework or default_test_framework,
},
"formatter_cmds": {"choices": formatter_suggestions, "default": configured_formatter or default_formatter},
"module_root": {"choices": module_root_suggestions, "default": default_module_root},
"tests_root": {"choices": tests_root_suggestions, "default": default_tests_root},
"test_framework": {"choices": test_framework_suggestions, "default": default_test_framework},
"formatter_cmds": {"choices": formatter_suggestions, "default": default_formatter},
}


Expand Down Expand Up @@ -319,7 +293,13 @@ def init_project(params: ValidateProjectParams) -> dict[str, str]:
}

args = process_args()
return {"status": "success", "moduleRoot": args.module_root, "pyprojectPath": pyproject_toml_path, "root": root}
return {
"status": "success",
"moduleRoot": args.module_root,
"pyprojectPath": pyproject_toml_path,
"root": root,
"existingConfig": config,
}


def _initialize_optimizer_if_api_key_is_valid(api_key: Optional[str] = None) -> dict[str, str]:
Expand Down
Loading