-
Notifications
You must be signed in to change notification settings - Fork 22
Pytest discovery with fixtures for class instantiation #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codeflash Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|
@KRRT7 ready to review |
tests/test_unit_test_discovery.py
Outdated
| from typing import Any, Dict, List, Optional, Required, TypedDict, Union # noqa: UP035 | ||
| class LiteLLMParamsTypedDict(TypedDict, total=False): | ||
| model: str | ||
| custom_llm_provider: Optional[str] | ||
| tpm: Optional[int] | ||
| rpm: Optional[int] | ||
| order: Optional[int] | ||
| weight: Optional[int] | ||
| max_parallel_requests: Optional[int] | ||
| api_key: Optional[str] | ||
| api_base: Optional[str] | ||
| api_version: Optional[str] | ||
| stream_timeout: Optional[Union[float, str]] | ||
| max_retries: Optional[int] | ||
| organization: Optional[Union[list, str]] # for openai orgs | ||
| ## DROP PARAMS ## | ||
| drop_params: Optional[bool] | ||
| ## UNIFIED PROJECT/REGION ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if all these are part of the original code and important to it, we should keep it, just skip this test for < 3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not super important actually, doesn't impact the actual test
PR Type
Tests
Description
Add pytest fixture discovery tests
Cover class method target resolution
Extend import analysis for fixtures
Diagram Walkthrough
File Walkthrough
test_unit_test_discovery.py
Add pytest fixture discovery and import analysis teststests/test_unit_test_discovery.py
FunctionParentfor class context.topologicalSort.