Skip to content

⚡️ Speed up function get_merged_columns by 294% #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

⚡️ Speed up function get_merged_columns by 294% #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions datacompy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,14 +1088,21 @@ def get_merged_columns(
What suffix was used to distinguish when the original dataframe was
overlapping with the other merged dataframe.
"""
# Precompute column sets for O(1) lookups (core optimization)
merged_cols = merged_df.columns
merged_cols_set = set(merged_cols)
columns = []
suffix_str = "_" + suffix
for col in original_df.columns:
if col in merged_df.columns:
if col in merged_cols_set:
columns.append(col)
elif col + "_" + suffix in merged_df.columns:
columns.append(col + "_" + suffix)
else:
raise ValueError("Column not found: %s", col)
col_suffixed = col + suffix_str
if col_suffixed in merged_cols_set:
columns.append(col_suffixed)
else:
# Preserve the behavior & exception type/message
raise ValueError("Column not found: %s", col)
return columns


Expand Down