Skip to content

⚡️ Speed up function decimal_comparator by 9% #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

⚡️ Speed up function decimal_comparator by 9% #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion datacompy/spark/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,14 @@ def decimal_comparator():
"""

class DecimalComparator(str):
__slots__ = () # Disables instance __dict__ to reduce overhead

def __eq__(self, other):
return len(other) >= 7 and other[0:7] == "decimal"
# Minimize repeated computation for performance
# Faster than slicing and string comparison for this case
if isinstance(other, str):
return other.startswith("decimal")
return False

return DecimalComparator("decimal")

Expand Down