Skip to content

⚡️ Speed up function calculate_max_diff by 6% #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

⚡️ Speed up function calculate_max_diff by 6% #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions datacompy/spark/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from typing import Any, Dict, List, Tuple

import pandas as pd
import pyspark.sql
from ordered_set import OrderedSet

from datacompy.base import (
Expand Down Expand Up @@ -1213,12 +1214,12 @@ def calculate_max_diff(
float
max diff
"""
diff = dataframe.select(
(col(col_1).astype("float") - col(col_2).astype("float")).alias("diff")
)
abs_diff = diff.select(abs(col("diff")).alias("abs_diff"))
max_diff: float = (
abs_diff.where(isnan(col("abs_diff")) == False) # noqa: E712
dataframe.select(
abs(col(col_1).astype("float") - col(col_2).astype("float")).alias(
"abs_diff"
)
)
.agg({"abs_diff": "max"})
.collect()[0][0]
)
Expand Down