Skip to content

⚡️ Speed up method SQLCompiler.has_composite_fields by 46% #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method SQLCompiler.has_composite_fields by 46% #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion django/db/models/sql/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,12 @@ def apply_converters(self, rows, converters):
def has_composite_fields(self, expressions):
# Check for composite fields before calling the relatively costly
# composite_fields_to_tuples.
return any(isinstance(expression, ColPairs) for expression in expressions)
colpairs_type = ColPairs
# Use generator and return immediately upon finding the first match for performance
for expression in expressions:
if isinstance(expression, colpairs_type):
return True
return False

def composite_fields_to_tuples(self, rows, expressions):
col_pair_slices = [
Expand Down