Skip to content

⚡️ Speed up method MigrationQuestioner.ask_rename_model by 16% #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MigrationQuestioner.ask_rename_model by 16% #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion django/db/migrations/questioner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def __init__(self, defaults=None, specified_apps=None, dry_run=None):
self.defaults = defaults or {}
self.specified_apps = specified_apps or set()
self.dry_run = dry_run
self._ask_rename_model_default = self.defaults.get("ask_rename_model", False)

def ask_initial(self, app_label):
"""Should we create an initial migration for the app?"""
Expand Down Expand Up @@ -70,7 +71,7 @@ def ask_rename(self, model_name, old_name, new_name, field_instance):

def ask_rename_model(self, old_model_state, new_model_state):
"""Was this model really renamed?"""
return self.defaults.get("ask_rename_model", False)
return self._ask_rename_model_default

def ask_merge(self, app_label):
"""Should these migrations really be merged?"""
Expand Down