Skip to content

⚡️ Speed up method FeatureRegistryClientWithOverride.parse_feature_path by 24% #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method FeatureRegistryClientWithOverride.parse_feature_path by 24% #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions google/cloud/aiplatform/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@
reservation_affinity_v1 as gca_reservation_affinity_v1,
)

_FEATURE_PATH_PATTERN = re.compile(
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/featureGroups/(?P<feature_group>.+?)/features/(?P<feature>.+?)$"
)

VertexAiServiceClient = TypeVar(
"VertexAiServiceClient",
# v1beta1
Expand Down Expand Up @@ -730,10 +734,7 @@ def feature_path(
@staticmethod
def parse_feature_path(path: str) -> Dict[str, str]:
"""Parses a feature path into its component segments."""
m = re.match(
r"^projects/(?P<project>.+?)/locations/(?P<location>.+?)/featureGroups/(?P<feature_group>.+?)/features/(?P<feature>.+?)$",
path,
)
m = _FEATURE_PATH_PATTERN.match(path)
return m.groupdict() if m else {}

class FeatureRegistryServiceClientV1(
Expand Down