⚡️ Speed up method UploadStats._skipped_summary by 19%
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 19% (0.19x) speedup for
UploadStats._skipped_summaryingoogle/cloud/aiplatform/tensorboard/upload_tracker.py⏱️ Runtime :
103 microseconds→86.2 microseconds(best of514runs)📝 Explanation and details
The optimized code achieves an 18% speedup through several targeted optimizations:
1. Constant Pre-computation in
readable_bytes_string():2**10and2**20calculations to module-level constants_KBand_MB2. Single
time.time()Call in__init__():time.time()result in a variable to avoid potential duplicate calls3. Optimized String Building in
_skipped_summary():self._num_tensors_skippedandself._num_blobs_skippedto reduce attribute lookupsPerformance Impact by Test Case:
The optimizations show consistent improvements across all test scenarios:
The string building optimization is particularly effective because most real-world usage involves 0-2 items in the summary, making the direct conditional approach faster than the general-purpose list-and-join method.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-UploadStats._skipped_summary-mglr1o22and push.