Skip to content

⚡️ Speed up method MultipartUploadManager._get_file_type by 21% #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method MultipartUploadManager._get_file_type by 21% #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/together/filemanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,15 +452,18 @@ def upload(

def _get_file_type(self, file: Path) -> str:
"""Get file type from extension, raising ValueError for unsupported extensions"""
if file.suffix == ".jsonl":
return "jsonl"
elif file.suffix == ".parquet":
return "parquet"
elif file.suffix == ".csv":
return "csv"
else:
# Optimize by using a direct mapping lookup instead of chained if-elif-else
ext = file.suffix
ext_map = {
".jsonl": "jsonl",
".parquet": "parquet",
".csv": "csv",
}
try:
return ext_map[ext]
except KeyError:
raise ValueError(
f"Unsupported file extension: '{file.suffix}'. "
f"Unsupported file extension: '{ext}'. "
f"Supported extensions: .jsonl, .parquet, .csv"
)

Expand Down