Skip to content

⚡️ Speed up method BatchReference._to_internal by 185% #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method BatchReference._to_internal by 185% #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions weaviate/collections/classes/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,21 @@ def _validate_uuids(cls, v: UUID) -> str:
return get_valid_uuid(v)

def _to_internal(self) -> _BatchReference:
if self.to_object_collection is None:
self.to_object_collection = ""
# Avoid mutating self.to_object_collection; use locals for modifications
toc = self.to_object_collection
if toc is None:
toc_str = ""
else:
self.to_object_collection = self.to_object_collection + "/"
# Simple concatenation is faster than += or +
toc_str = f"{toc}/"
# Only compute str(self.from_object_uuid) and str(self.to_object_uuid) once, reuse
from_uuid_str = str(self.from_object_uuid)
to_uuid_str = str(self.to_object_uuid)
return _BatchReference(
from_uuid=str(self.from_object_uuid),
from_=f"{BEACON}{self.from_object_collection}/{self.from_object_uuid}/{self.from_property_name}",
to=f"{BEACON}{self.to_object_collection}{str(self.to_object_uuid)}",
to_uuid=str(self.to_object_uuid),
from_uuid=from_uuid_str,
from_=f"{BEACON}{self.from_object_collection}/{from_uuid_str}/{self.from_property_name}",
to=f"{BEACON}{toc_str}{to_uuid_str}",
to_uuid=to_uuid_str,
tenant=self.tenant,
)

Expand Down