-
Notifications
You must be signed in to change notification settings - Fork 0
add new link component with optional icon #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <span class='flex'> | ||
| <% if @icon.present? %> | ||
| <%= image_tag icon_image_path, alt: icon_alt_text, class: "size-[20px]" %> | ||
| <% end %> | ||
| <%= link_to @label, @url, target: "_blank", rel: "noopener noreferrer" %> | ||
| </span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| class LinkComponent < ViewComponent::Base | ||
| def initialize(label:, url:, icon: nil) | ||
| @label = label | ||
| @url = url | ||
| @icon = icon | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def icon_image_path | ||
| case @icon | ||
| when "info" | ||
| "icons/information.svg" | ||
| else | ||
| "" | ||
| end | ||
| end | ||
|
|
||
| def icon_alt_text | ||
| descriptor = case @icon | ||
| when "info" | ||
| "info" | ||
| else | ||
| "" | ||
| end | ||
| descriptor + " icon" | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require "test_helper" | ||
|
|
||
| class LinkComponentTest < ViewComponent::TestCase | ||
| def test_component_renders_something_useful | ||
| # assert_equal( | ||
| # %(<span>Hello, components!</span>), | ||
| # render_inline(LinkComponent.new(message: "Hello, components!")).css("span").to_html | ||
| # ) | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| class LinkComponentPreview < ViewComponent::Preview | ||
| def default | ||
| render(LinkComponent.new(label: I18n.t("continue"), url: "/continue")) | ||
| end | ||
|
|
||
| def with_icon | ||
| render(LinkComponent.new(label: I18n.t("continue"), url: "/continue", icon: "info")) | ||
| end | ||
| end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEBBLE: if we're not putting a real test here, I'd prefer this file to not exist to not clutter the codebase. Curious how CFA feels though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently repo has no tests and stubs for all tests - talked over this w Mike/Kat and I'm fine leaving as is