Skip to content

Conversation

@danielh-codefresh
Copy link

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #89 (2b59352) into release-3.2 (734c781) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2b59352 differs from pull request most recent head c875261. Consider uploading reports for the commit c875261 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.2      #89      +/-   ##
===============================================
- Coverage        48.60%   48.59%   -0.02%     
===============================================
  Files              265      265              
  Lines            19234    19238       +4     
===============================================
  Hits              9348     9348              
- Misses            8835     8840       +5     
+ Partials          1051     1050       -1     
Impacted Files Coverage Δ
workflow/controller/operator.go 71.18% <0.00%> (-0.10%) ⬇️
pkg/apiclient/offline-client.go 0.00% <0.00%> (ø)
pkg/apiclient/argo-kube-client.go 0.00% <0.00%> (ø)
pkg/apiclient/panic-intermediary.go 0.00% <0.00%> (ø)
...lient/error-translating-workflow-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
.../http1/cluster-workflow-template-service-client.go 0.00% <0.00%> (ø)
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9011409...c875261. Read the comment docs.

@danielh-codefresh danielh-codefresh merged commit e874ec1 into release-3.2 Jan 10, 2022
@noam-codefresh noam-codefresh deleted the CR-8501 branch July 5, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants