-
Notifications
You must be signed in to change notification settings - Fork 2
Fix the example of the code to get pipelines in README file #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As from discussion (#1) it seems like some functions were renamed. this example works perfectly for 0.5.0, probably should be adjusted according to changes in 0.5.1 |
funkycode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is fix for 0.5.1
|
Thanks! |
|
Btw offtopic, But as you have context and ClientOptions. I would suggest to have something like (surely I would suggest to have all values passed from context to options (below is just a sample, if you want I can create other pull request for this too, just not sure what would be your approach - maybe you would want to have New() to accept context instead) func (c *CFContext) GetClientOptions() *ClientOptions {
return &ClientOptions{Host: c.URL,
Auth: AuthOptions{Token: c.Token}}
} |
Done. |
|
Have to agree with you on it #2 (comment) |
|
I'll try to push another merge request tomorrow to use context instead of options (or maybe options to have both optionally?) |
|
In general, users probably need the ability to create a client from |
Here is working example.