Tawsif fix asyncify promise return type #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawsifkamal
requested review from
caroljung-cg
and removed request for
a team
|
codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
bagel897
approved these changes
Feb 6, 2025
EdwardJXLi
approved these changes
Feb 6, 2025
jayhack
pushed a commit
that referenced
this pull request
Feb 9, 2025
# Motivation - changed asyncify bug If the normal function already returns a promise, do not surround Promise<> type as async function collapses promises. - when a function is already returning a promise, making it async will not make it return <Promise<Promise<any>> - It will just stay Promise<any> as is Co-authored-by: codegen-bot <team+codegenbot@codegen.sh>
tkfoss
pushed a commit
that referenced
this pull request
Feb 10, 2025
# Motivation - changed asyncify bug If the normal function already returns a promise, do not surround Promise<> type as async function collapses promises. - when a function is already returning a promise, making it async will not make it return <Promise<Promise<any>> - It will just stay Promise<any> as is Co-authored-by: codegen-bot <team+codegenbot@codegen.sh>
|
Wahooooo good job bro creating shareholder value 😍😤😤🔥🔥🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
changed asyncify bug
If the normal function already returns a promise, do not surround Promise<> type as async function collapses promises.
when a function is already returning a promise, making it async will not make it return <Promise<Promise>
It will just stay Promise as is