[CG-10833] feat: remove unpacking assignment #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagel897
suggested changes
Feb 14, 2025
Contributor
bagel897
left a comment
bagel897
left a comment
There was a problem hiding this comment.
Forward from other pr, can we do _smart_remove instead of overriding remove?
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
Contributor
Author
I need to know what Assignment it's being called on and remove dissolves it into Value which does not preserve the distinction, if there is a better idea than override let me know |
bagel897
suggested changes
Feb 19, 2025
bagel897
approved these changes
Feb 20, 2025
Contributor
|
🎉 This PR is included in version 0.26.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review