Skip to content

Remix Icon is breaking QuickAccessItems into Header #134

@maximallain

Description

@maximallain

Context

I just migrated 2 libs in my project :

  • react-dsfr : 0.54.0 => 0.57.4
  • tss-react : 4.5.2 => 4.7.4

Then I discovered these regression

Before

image

After

image

Here is the code

<Header
        brandTop={brandTop}
        serviceTitle={title}
        homeLinkProps={homeLinkProps}
        quickAccessItems={[
          {
            iconId: "fr-icon-account-circle-line",
            linkProps: {
              href: "#",
              className: classes.disabled,
            },
            text: "Me connecter",
          },
          {
            iconId: "ri-chat-3-line",
            linkProps: {
              href: feedbackLink || "#",
              target: "_self",
            },
            text: "Soumettre mes retours",
          },
          {
            iconId: "ri-mail-line",
            linkProps: {
              href: `mailto:${contactMail}`,
            },
            text: "Nous contacter",
          },
        ]}
        serviceTagline="Prototype - Version1 - 2023"
      />

Solution path ?

I replaced Remix icons by dsfr icons, and it works backs.

image

With this code

{
  iconId: "fr-icon-account-circle-line",
  linkProps: {
    href: feedbackLink || "#",
    target: "_self",
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions