Support of button attributes on MainNavigation

[enguerranws]

On MainNavigation component, a navigation item is rendered as a <Link> element if linkProps has been set, otherwise, it's rendered as a <button>.

The use case is that we use id attribute (tracking, e2e testing, etc.). It's possible on items using linkProps, but not if linkProps is not used.

{
      text: "Nav item as <button>",
      isActive: isNavItemActive,
      //id: "not-working-id",
      menuLinks: [
        {
          text: "Sub nav item",
          linkProps: {
            ...routes.myRoute().link,
            id: "my-working-link-id",
          }
        },

Should we add a buttonProps in MainNavigationProps.Item that satisfies React.HTMLProps<HTMLButtonElement> ?

[garronej]

@enguerranws Agreed,

It's in: cc16b81

Thanks for the suggestion.