Button onClick can be optional #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue: I did want to use this component as a submit button form a form element, but its typing doesn't allow the usage as a without a onClick prop.
I'm not sure passing onClick as optional is the best option, but even as a
<button type="button">, I'm not sure we should constrain the user to pass a onClick prop.Alternatively, we could pass onClick as optional if the button
typeattribute issubmitorreset.