Input adjustements #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this component, I thought some
<label>related improvments could be useful:hideLabelprop: not documented on DSFR docs, but we could allow users to provide a valid label but hide it (using sr-only to make it still readable by screen readers).fr-upload-group: I was about creating a new component (to follow DSFR naming and docs), but it appears that Input and File are just the same, only the wrapper class is changing. Maybe we should create a File component that just wraps Input component?