Skip to content

Conversation

@jjpxiii
Copy link
Contributor

@jjpxiii jjpxiii commented Mar 2, 2023

No description provided.

@garronej
Copy link
Collaborator

garronej commented Mar 2, 2023

Thank you very much!
Could you just approve my suggestion, my script for listing export dosent work on windows apparently..

@jjpxiii jjpxiii force-pushed the feature/enable-a11y-addon branch from df59150 to 6abef36 Compare March 2, 2023 21:40
@jjpxiii
Copy link
Contributor Author

jjpxiii commented Mar 2, 2023

Thanks Joseph, I'll be more careful next time and I also will try to make the build scripts working on Windows, what do you think ?

@garronej
Copy link
Collaborator

garronej commented Mar 2, 2023

Thank you very much for your proposal.
Don't worry about it though, I just fixed it, I think.
If you are willing to contribute futher there is many more miningfull things on the todo list :)
Anyway thank you for that!

@garronej garronej merged commit 5222019 into codegouvfr:main Mar 2, 2023
enguerranws pushed a commit that referenced this pull request Mar 3, 2023
Co-authored-by: jjpxiii <jjpxiii@github.com>
enguerranws pushed a commit that referenced this pull request Mar 3, 2023
Co-authored-by: jjpxiii <jjpxiii@github.com>
garronej added a commit that referenced this pull request Mar 3, 2023
enguerranws pushed a commit that referenced this pull request Mar 16, 2023
Co-authored-by: jjpxiii <jjpxiii@github.com>
enguerranws pushed a commit that referenced this pull request Mar 17, 2023
Co-authored-by: jjpxiii <jjpxiii@github.com>
enguerranws pushed a commit that referenced this pull request Mar 28, 2023
Co-authored-by: jjpxiii <jjpxiii@github.com>
garronej pushed a commit that referenced this pull request Mar 28, 2023
* Enable a11y addon for accessibility testing (#67)

Co-authored-by: jjpxiii <jjpxiii@github.com>

* rm unused imports

* rename dismiss -> isDismissible

* mark Tag as done in doc

* DataAttribute type is more readable

* added type test on Tag component

* review fixes: isDismissible, isSmall, test against undefined for non-bool values

---------

Co-authored-by: Jean-Jérôme Pantalacci <jjpxiii@gmail.com>
Co-authored-by: jjpxiii <jjpxiii@github.com>
sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants