Fix duplicated IDs issue while using multiple modals in a single page #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Title: Fix duplicated IDs issue while using multiple modals in a single page Description: This pull request addresses the issue of duplicated IDs by modifying the code to use the modal ID for creating the H1 ID. This change ensures that the H1 ID remains unique, even when multiple modals are present on the same page. Signed-off-by: Clément Lelong <clement@numericite.eu>
ClementNumericite
changed the title
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Clément Lelong <clement@numericite.eu>
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Clément Lelong <clement@numericite.eu>
Co-authored-by: Joseph Garrone <joseph.garrone.gj@gmail.com> Signed-off-by: Clément Lelong <clement@numericite.eu>
ClementNumericite
requested review from
garronej
and removed request for
garronej
garronej
reviewed
Mar 16, 2023
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This pull request addresses the issue of duplicated IDs by modifying the code to use the modal ID for creating the H1 ID. This change ensures that the H1 ID remains unique, even when multiple modals are present on the same page.