Skip to content

Conversation

@damienguezou
Copy link
Collaborator

Hello,

A little fix of a type. The submenu items should be optional

@garronej
Copy link
Collaborator

Hi @damienguezou,

Thanks for your contribution.

The submenu items should be optional

Does it though? I don't see it.

@damienguezou
Copy link
Collaborator Author

I think, for direct access : the first case of this page : https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/menu-lateral and in the storybook the first example show a menu without submenu items, but when I try it, there is a typescript issue

There is no submenu, so if I am not wrong it should be optional or maybe I miss something

@garronej
Copy link
Collaborator

LOL. Ok I see.
The person who made this component got confused between & and |.
Releasing a fix.

@garronej garronej closed this Mar 20, 2023
garronej added a commit that referenced this pull request Mar 20, 2023
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
@damienguezou
Copy link
Collaborator Author

Oh yes, didn't see that. My bad

Thanks

@damienguezou damienguezou deleted the bugfix/fix-sidebar-props branch March 20, 2023 12:56
@garronej
Copy link
Collaborator

Don't mention it, types can be confusing.
Thanks for reporting!

garronej added a commit that referenced this pull request Mar 20, 2023
@garronej
Copy link
Collaborator

Hey @damienguezou, sorry took me a wile to fix all the errors in this components... but the fix should be released in a few minutes.

enguerranws pushed a commit that referenced this pull request Mar 28, 2023
Signed-off-by: Joseph Garrone <joseph.garrone.gj@gmail.com>
enguerranws pushed a commit that referenced this pull request Mar 28, 2023
sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants