feat: Add password functional block #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Not sure that we should implement functional blocks of the DSFR? |
Collaborator
|
@enguerranws Yes I think it does serve a purpose. @damienguezou @enguerranws @gary-van-woerkens I've done this PR in video. (You can watch it in x2) |
Collaborator
Author
|
@garronej Thanks for the review, I will takes notes for futur contribution |
enguerranws
pushed a commit
that referenced
this pull request
Mar 28, 2023
* feat: Add password functional block * #91 --------- Co-authored-by: GUEZOU Damien <dguezou@jouve.fr> Co-authored-by: garronej <joseph.garrone@data.gouv.fr>
Collaborator
Screen.Recording.2023-04-21.at.02.27.13.movMaybe we should make so that the label is not positionned because when the info appear it push the content bellow |
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implémentation of the password functional block : https://www.systeme-de-design.gouv.fr/elements-d-interface/modeles-et-blocs-fonctionnels/demande-de-mot-de-passe
Not sure about the typing of the props. I based them from the InputProps but not sure that was a good idea. Let met know if you think it's better to have an independent typing, I will do the change.
The pre-commit hook change the export on the package.json and not sure how it's works. I let the package.json on the pull request but let me know if I have to do something. It doesn't add the PasswordInput in the list but I think it's because I put it under a "blocks" folder. Same, let me know if I have to move the component or change something