Skip to content

Conversation

@nkokla
Copy link
Contributor

@nkokla nkokla commented Mar 28, 2023

Fix typo on Modalcomponent code description.

@garronej
Copy link
Collaborator

Great thanks!

@nkokla
Copy link
Contributor Author

nkokla commented Mar 28, 2023

I found another error.
I convert to a draft and correct it before sending it back.

@nkokla nkokla marked this pull request as draft March 28, 2023 16:53
@garronej
Copy link
Collaborator

Great thanks,
By the way. I'm not very happy of the modal component. It's not done. We should be able to open and close the modal programmatically, we only provideo a way to open it when a boutton is clicked wich isn't great.

@nkokla
Copy link
Contributor Author

nkokla commented Mar 28, 2023

Yes I see that. 🤷‍♂️
After fixing this document error, do you want I send a proposal? 😊

@garronej
Copy link
Collaborator

Yes, I'd love it.
Be aware though that the vetting process can be slow.
There is often a lot of back and forth before the component make it in the codebase.
Aslo whenever possible, we try to make RSC ready component (See Server Component).
When it's not possible we add a "use client"; header.

nkokla and others added 2 commits March 29, 2023 09:47
Signed-off-by: Nicolas KOKLA <1872767+nkokla@users.noreply.github.com>
@nkokla
Copy link
Contributor Author

nkokla commented Mar 29, 2023

I don't understand why the ci/test_format failed.
An idea ?

@garronej
Copy link
Collaborator

Just run yarn format it'll fix it.
There is a pre commit hooks that runs it automatically...

@nkokla
Copy link
Contributor Author

nkokla commented Mar 29, 2023

Exactly, the yarn format appear to be OK. (No errors or modification into the code)
This is the cause why i don't understand. 🤷‍♂️

@garronej
Copy link
Collaborator

Hum, yes indeed, very strange.

@garronej
Copy link
Collaborator

It's so strange.
I don't understand what's going on.
I checked out your branch and indeed when I run yarn format, no changes and yarn format:check exits with 0 (sucess) but for some reason in the CI in fails.

Well, whatever, don't worry about it, I'll fore merge.

@nkokla nkokla marked this pull request as ready for review March 29, 2023 23:27
@garronej garronej merged commit 8fd33c9 into codegouvfr:main Mar 31, 2023
@garronej
Copy link
Collaborator

Thank you!

sbourdon13 pushed a commit to sbourdon13/react-dsfr that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants