-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add support for MasonryFlashlist #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hey @e-younan, made this a draft PR as I wanted to get some feedback from you first 🙏🏼 |
|
Hey @rafpato, thanks for opening this! I'll review it now. 😄 |
e-younan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues to fix, but looks good to me. On the Getting Started page of the documentation, you should extend the following section:
Here is another If you intend to use the [FlashListWithHeaders](http://localhost:3000/docs/components/flash-list-with-headers) component, please ensure that you review the [Compatibilty table](http://localhost:3000/docs/getting-started#compatibility) above and install the correct versions of each library.
to mention the new component you added.
Thanks so much for the feedback! I've made all the requested changes 😇 As for the documentation, I added that the component is only available in 0.14.0 assuming it would be available in the next version. |
e-younan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 😄
Description
This PR adds support for the Masonry Flashlist Layout
Motivation and Context
Since FlashList is already supported, this additional layout is a nice win (I also need it in my app).
The API is pretty much the same except some props that are not supported:
How Has This Been Tested?
I ran the example app on iOS and Android emulators, please find some videos below
react-native-header-android.mp4
react-native-header-ios.mp4
Types of changes
Checklist:
Additional Notes (Optional)
I wasn't sure what to do with the docs so I just duplicated the FlashList page for now but I think we should add there: