Skip to content

Conversation

@rafpato
Copy link
Contributor

@rafpato rafpato commented Oct 17, 2024

Description

This PR adds support for the Masonry Flashlist Layout

Motivation and Context

Since FlashList is already supported, this additional layout is a nice win (I also need it in my app).
The API is pretty much the same except some props that are not supported:

How Has This Been Tested?

I ran the example app on iOS and Android emulators, please find some videos below

Android iOS
react-native-header-android.mp4
react-native-header-ios.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have followed the guidelines in the README.md file.
  • I have updated the documentation as necessary.
  • My changes generate no new warnings.

Additional Notes (Optional)

I wasn't sure what to do with the docs so I just duplicated the FlashList page for now but I think we should add there:

  • which version this will be released in?
  • perhaps update the compatibility matrix?

@rafpato
Copy link
Contributor Author

rafpato commented Oct 17, 2024

hey @e-younan, made this a draft PR as I wanted to get some feedback from you first 🙏🏼

@e-younan
Copy link
Member

Hey @rafpato, thanks for opening this! I'll review it now. 😄

Copy link
Member

@e-younan e-younan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues to fix, but looks good to me. On the Getting Started page of the documentation, you should extend the following section:

Here is another If you intend to use the [FlashListWithHeaders](http://localhost:3000/docs/components/flash-list-with-headers) component, please ensure that you review the [Compatibilty table](http://localhost:3000/docs/getting-started#compatibility) above and install the correct versions of each library.

to mention the new component you added.

@rafpato rafpato marked this pull request as ready for review October 18, 2024 15:56
@rafpato
Copy link
Contributor Author

rafpato commented Oct 18, 2024

Minor issues to fix, but looks good to me. On the Getting Started page of the documentation, you should extend the following section:

Here is another If you intend to use the [FlashListWithHeaders](http://localhost:3000/docs/components/flash-list-with-headers) component, please ensure that you review the [Compatibilty table](http://localhost:3000/docs/getting-started#compatibility) above and install the correct versions of each library.

to mention the new component you added.

Thanks so much for the feedback! I've made all the requested changes 😇

As for the documentation, I added that the component is only available in 0.14.0 assuming it would be available in the next version.

@rafpato rafpato requested a review from e-younan October 18, 2024 17:39
Copy link
Member

@e-younan e-younan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 😄

@e-younan e-younan merged commit 52ba9a3 into codeherence:main Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants