Adding Environments

[okatse]

class ExceptionHandler Line 78

            if (! str_contains($request->getHeaderLine('accept'), 'text/html')) {
                $data = (ENVIRONMENT === 'development' || ENVIRONMENT === 'testing')
                    ? $this->collectVars($exception, $statusCode)
                    : '';

If I add a new environment, this piece of code causes data trimming. Could this be modularized ?
Example :

           $som_config = new \Config\App();

            if (! str_contains($request->getHeaderLine('accept'), 'text/html')) {
                $data = (in_array(ENVIRONMENT, $som_config->som_env))
                    ? $this->collectVars($exception, $statusCode)
                    : '';

[kenjis]

Why do you need this?

[okatse]

Clarify. Why do I need to add a new environment ? Modification in the code is required because - the newly created environment does not return errors
Or newly created environment = alweys production

[michalsn]

I wonder why we hardcoded these environments for non-HTML responses, while in ExceptionHandler::determineView() we rely (more or less) on the display_errors setting: https://github.com/codeigniter4/CodeIgniter4/blob/develop/system/Debug/ExceptionHandler.php#L137.

Is there a reason why we should not follow the same rule here?

[kenjis]

@okatse What environment do you add? Why not using development when you want to see the errors?

[kenjis]

@michalsn Yes, it seems it is inconsistent.

[michalsn]

It has already been fixed in 4.6 branch.