-
Notifications
You must be signed in to change notification settings - Fork 2k
Releases Refactor #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases Refactor #2668
Conversation
|
Due to the nature of the trigger, this change is not easily tested. I created forks of the three repos
|
| # Prepare the target | ||
| cd $TARGET | ||
| git checkout master | ||
| rm -rf * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command scares me :) Can you explain it is doing. Seems like you checkout master branch then delete everything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way the old script worked it would copy in the chosen files (like we do below) pre-wiping any directories (this was the bugged part from the cprm typo). Where that fails is when there are files that are renamed or removed (notice we have license.txt and a duplicate legacy LICENSE because of this). Using the modified version above it checks out the target repo (AppStarter or framework) and rebuilds the repo from scratch (* ignores files with leading periods so it doesn’t affect the .git directory). Also, it’s just a new commit so we could always back up one and nothing is lost!
|
Other than the delete the entire server command making me nervous it all looks good. :) |
|
Come on @lonnieezell, you know you want to..... |
|
Oh, all right @MGatner :) |
Description
This PR is "phase 1" of automating releases, targeting the distribution repos.
Checklist: