Skip to content

build(deps-dev): update friendsofphp/php-cs-fixer requirement from 3.6.* to 3.9.* #6252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

build(deps-dev): update friendsofphp/php-cs-fixer requirement from 3.6.* to 3.9.* #6252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d89566
update friendsofphp/php-cs-fixer requirement
paulbalandan Jul 16, 2022
eba1938
Update composer.json
paulbalandan Aug 18, 2022
5dbe83d
Update composer.json
paulbalandan Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ on:
- '**.php'
- 'spark'
- '.github/workflows/test-coding-standards.yml'
- 'composer.json'
pull_request:
paths:
- '**.php'
- 'spark'
- '.github/workflows/test-coding-standards.yml'
- 'composer.json'

jobs:
lint:
Expand Down
2 changes: 1 addition & 1 deletion admin/framework/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"require-dev": {
"codeigniter/coding-standard": "^1.1",
"fakerphp/faker": "^1.9",
"friendsofphp/php-cs-fixer": "3.6.*",
"friendsofphp/php-cs-fixer": "~3.10.0",
Copy link
Member

@kenjis kenjis Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ~3.10.0? ^3.10 seems fine.

Copy link
Member

@paulbalandan paulbalandan Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tilde is the same with the *. It limits version to the patch

Copy link
Member

@kenjis kenjis Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ git diff
diff --git a/composer.json b/composer.json
index 080fc5974..e471a6452 100644
--- a/composer.json
+++ b/composer.json
@@ -17,7 +17,7 @@
     "require-dev": {
         "codeigniter/coding-standard": "^1.1",
         "fakerphp/faker": "^1.9",
-        "friendsofphp/php-cs-fixer": "3.6.*",
+        "friendsofphp/php-cs-fixer": "~3.9.0",
         "mikey179/vfsstream": "^1.6",
         "nexusphp/cs-config": "^3.3",
         "nexusphp/tachycardia": "^1.0",
$ composer update
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 2 updates, 1 removal
  - Removing php-cs-fixer/diff (v2.0.2)
  - Upgrading friendsofphp/php-cs-fixer (v3.6.0 => v3.9.6)
  - Upgrading nexusphp/cs-config (v3.4.0 => v3.5.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 2 updates, 1 removal
  - Removing php-cs-fixer/diff (v2.0.2)
  - Upgrading friendsofphp/php-cs-fixer (v3.6.0 => v3.9.6): Extracting archive
  - Upgrading nexusphp/cs-config (v3.4.0 => v3.5.0): Extracting archive
Generating optimized autoload files
53 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
infection/extension-installer: No extensions found
> CodeIgniter\ComposerScripts::postUpdate
> bash -c "if [ -f admin/setup.sh ]; then bash admin/setup.sh; fi"
No security vulnerability advisories found

Copy link
Member

@MGatner MGatner Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prevents us from going to 3.11.x which I believe is our desired behavior.

https://getcomposer.org/doc/articles/versions.md#tilde-version-range-

"mikey179/vfsstream": "^1.6",
"nexusphp/cs-config": "^3.3",
"phpunit/phpunit": "^9.1",
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"require-dev": {
"codeigniter/coding-standard": "^1.1",
"fakerphp/faker": "^1.9",
"friendsofphp/php-cs-fixer": "3.6.*",
"friendsofphp/php-cs-fixer": "~3.10.0",
"mikey179/vfsstream": "^1.6",
"nexusphp/cs-config": "^3.3",
"nexusphp/tachycardia": "^1.0",
Expand Down