Skip to content

test: remove dynamic properties in MigrationRunnerTest #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

test: remove dynamic properties in MigrationRunnerTest #6667

merged 1 commit into from
Oct 12, 2022

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Oct 11, 2022 •
edited
Loading

Description
See #6170, #6172

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Oct 11, 2022
@kenjis kenjis mentioned this pull request Oct 11, 2022
Closed
7 tasks
@kenjis kenjis added the PHP 8.2 label Oct 12, 2022
MGatner
MGatner approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironic that the properties weren't even needed to begin with 😆

@kenjis
Copy link
Member Author

kenjis commented Oct 12, 2022

Isn't it a remnant of an old implementation?

@kenjis kenjis merged commit 0aab056 into codeigniter4:develop Oct 12, 2022
@kenjis kenjis deleted the fix-MigrationRunnerTest-dynamic-property branch October 12, 2022 10:19
@MGatner
Copy link
Member

MGatner commented Oct 13, 2022

Maybe? Refactoring Migration Runner was one of my first larger projects, but it was so long ago I remember next to nothing about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

testing Pull requests that changes tests only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner