Skip to content

Group runInSeparateProcess and preserveGlobalState #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Group runInSeparateProcess and preserveGlobalState #6788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
862f883
Group `runInSeparateProcess` and `preserveGlobalState`
paulbalandan Oct 30, 2022
72412cf
Trim whitespace in preserveGlobalState
paulbalandan Oct 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/system/Commands/GenerateKeyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ public function testGenerateKeyShowsEncodedKey()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testGenerateKeyCreatesNewKey()
{
Expand Down
3 changes: 1 addition & 2 deletions tests/system/CommonFunctionsSendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ protected function setUp(): void
* See https://github.com/codeigniter4/CodeIgniter4/issues/1393
*
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testRedirectResponseCookiesSent()
{
Expand Down
25 changes: 8 additions & 17 deletions tests/system/CommonFunctionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ public function testEscapeBadContextZero()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testSessionInstance()
{
Expand All @@ -197,8 +196,7 @@ public function testSessionInstance()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testSessionVariable()
{
Expand All @@ -211,8 +209,7 @@ public function testSessionVariable()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testSessionVariableNotThere()
{
Expand Down Expand Up @@ -295,8 +292,7 @@ public function testModelExistsAbsoluteClassname()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testOldInput()
{
Expand Down Expand Up @@ -331,8 +327,7 @@ public function testOldInput()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testOldInputSerializeData()
{
Expand Down Expand Up @@ -367,8 +362,7 @@ public function testOldInputSerializeData()
* @see https://github.com/codeigniter4/CodeIgniter4/issues/1492
*
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testOldInputArray()
{
Expand Down Expand Up @@ -481,7 +475,6 @@ public function testRedirectResponseCookies1()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
*/
public function testTrace()
Expand All @@ -505,8 +498,7 @@ public function testViewNotSaveData()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testForceHttpsNullRequestAndResponse()
{
Expand Down Expand Up @@ -586,8 +578,7 @@ public function testDWithCSP()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testTraceWithCSP()
{
Expand Down
9 changes: 3 additions & 6 deletions tests/system/Config/BaseConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ public function testUseDefaultValueTypeStringValue()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testServerValues()
{
Expand Down Expand Up @@ -177,8 +176,7 @@ public function testSetsDefaultValues()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testSetsDefaultValuesEncryptionUsingHex2Bin()
{
Expand All @@ -193,8 +191,7 @@ public function testSetsDefaultValuesEncryptionUsingHex2Bin()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testSetDefaultValuesEncryptionUsingBase64()
{
Expand Down
3 changes: 1 addition & 2 deletions tests/system/Config/ConfigTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ public function testCreateNonConfig()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testInjection()
{
Expand Down
6 changes: 2 additions & 4 deletions tests/system/Config/DotEnvTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,7 @@ public function provideLoadVars(): iterable

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testLoadsHex2Bin()
{
Expand All @@ -98,8 +97,7 @@ public function testLoadsHex2Bin()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testLoadsBase64()
{
Expand Down
21 changes: 7 additions & 14 deletions tests/system/Config/ServicesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,7 @@ public function testNewViewcell()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testNewSession()
{
Expand All @@ -249,8 +248,7 @@ public function testNewSession()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testNewSessionWithNullConfig()
{
Expand All @@ -260,8 +258,7 @@ public function testNewSessionWithNullConfig()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testCallStatic()
{
Expand All @@ -275,8 +272,7 @@ public function testCallStatic()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testCallStaticDirectly()
{
Expand All @@ -287,8 +283,7 @@ public function testCallStaticDirectly()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testMockInjection()
{
Expand All @@ -310,8 +305,7 @@ public function testMockInjection()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testReset()
{
Expand All @@ -330,8 +324,7 @@ public function testReset()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testResetSingle()
{
Expand Down
3 changes: 1 addition & 2 deletions tests/system/Events/EventsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ protected function tearDown(): void

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testInitialize()
{
Expand Down
6 changes: 2 additions & 4 deletions tests/system/Filters/HoneypotTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ public function testBeforeClean()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testAfter()
{
Expand All @@ -103,8 +102,7 @@ public function testAfter()

/**
* @runInSeparateProcess
*
* @preserveGlobalState disabled
* @preserveGlobalState disabled
*/
public function testAfterNotApplicable()
{
Expand Down
Loading