Skip to content

New Year 2023 #7050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2023
Merged

New Year 2023 #7050

merged 3 commits into from
Jan 5, 2023

Conversation

@mostafakhudair
Copy link
Contributor

New Year 2023

datamweb
datamweb reviewed Jan 4, 2023
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #5520

kenjis
kenjis requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update:

CodeIgniter4/user_guide_src/source/conf.py

Line 140 in e035451

epub_copyright = '2019-2022 CodeIgniter Foundation'

The value is the same as the variable copyright.

epub_copyright = copyright

is better?

@ddevsr
Copy link
Collaborator

ddevsr commented Jan 5, 2023 •
edited
Loading

I think in file user_guide_src/source/conf.py using latest year date is better.

yearNow = datetime.date.today().year

MGatner
MGatner approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's handle the UG changes separately.

@samsonasik samsonasik merged commit 7cb8917 into codeigniter4:develop Jan 5, 2023
@samsonasik
Copy link
Member

Thank you @mostafakhudair

@kenjis kenjis mentioned this pull request Jan 6, 2023
Merged
5 tasks
@kenjis
Copy link
Member

kenjis commented Jan 6, 2023

I sent a PR #7056
But where is the epub copyright year printed?

@datamweb
Copy link
Contributor

datamweb commented Jan 7, 2023

Screenshot 2023-01-07 131337

@kenjis
Copy link
Member

kenjis commented Jan 7, 2023

It is the HTML version.

I didn't find the copyright year in EPUB version.
We use the same variable to EPUB, so it is probably no problem, though.

@mostafakhudair mostafakhudair deleted the patch-3 branch October 6, 2023 05:40
@datamweb datamweb mentioned this pull request Mar 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis requested changes

@MGatner MGatner MGatner approved these changes

+2 more reviewers

@totoprayogo1916 totoprayogo1916 totoprayogo1916 approved these changes

@datamweb datamweb datamweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mostafakhudair @ddevsr @samsonasik @kenjis @datamweb @totoprayogo1916 @MGatner