Skip to content

Prep for 4.3.0 release #7072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2023
Merged

Prep for 4.3.0 release #7072

merged 2 commits into from
Jan 10, 2023

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Jan 10, 2023 •
edited
Loading

Description
Updates changelog and version references for 4.3.0.

Ref #7062
See #7071

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

lonnieezell
lonnieezell approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved it - but that's a long list of breaking changes and project space files that changed. Hopefully we can trim that back if we do another point release.

totoprayogo1916
totoprayogo1916 reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@totoprayogo1916 totoprayogo1916 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • phpstan-baseline.neon.dist
  • psalm-baseline.xml
  • psalm.xml
  • psalm_autoload.php
  • rector.php

All of this is only in the main repo, not in the appstarter or framework, does it need to be included here?

@kenjis
Copy link
Member Author

kenjis commented Jan 10, 2023

@totoprayogo1916 Thanks. Removed.

@kenjis
Copy link
Member Author

kenjis commented Jan 10, 2023

@lonnieezell

Hopefully we can trim that back if we do another point release.

Do you mean in next minor release 4.4.0 ?

@kenjis kenjis merged commit a7cd7a3 into develop Jan 10, 2023
This was referenced Jan 15, 2023
Merged
Merged
@kenjis kenjis deleted the release-4.3.0 branch January 15, 2023 02:53
@kenjis kenjis mentioned this pull request Feb 17, 2023
Merged
5 tasks
@kenjis kenjis mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

+1 more reviewer

@totoprayogo1916 totoprayogo1916 totoprayogo1916 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis @lonnieezell @totoprayogo1916