-
Notifications
You must be signed in to change notification settings - Fork 2k
style: Enable phpdoc_list_type fixer
#8530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi, @paulbalandan! |
|
@paulbalandan Sorry, I've changed to use |
|
I'm not sure we should enable this rule by default. |
911abfd to
e84e626
Compare
|
Yes, it is risky by the reasoning behind it. If we make a phpdoc like |
I checked all the changes in this PR, and you are right. I agree to enable |
fa9e27d to
e37b8a3
Compare
|
To be merged once latest coding-standard is out. |
e37b8a3 to
ac31bd2
Compare
ac31bd2 to
06353a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Psalm errors are not directly related to this PR.
Description
Enables
phpdoc_list_type, changingarrayphpdocs with implicit keys tolist, e.g.array<string> => list<string>. Then let phpstan catch incorrect usages.If approved, don't merge yet so this can be applied in the coding standard repo and minimize updating the overrides here.
Checklist: