fix: quote reserved keyword timestamp used as a field name for session table
#9805
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion data with mysqli
neznaika0
approved these changes
Nov 20, 2025
Contributor
neznaika0
left a comment
neznaika0
left a comment
There was a problem hiding this comment.
In most cases, I put quotes for the names of the fields/tables. To avoid such situations.
samsonasik
approved these changes
Nov 20, 2025
paulbalandan
approved these changes
Nov 20, 2025
Member
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in the session table schema for
mysqlidriver.The
timestampfield name in the session table is a reserved keyword in MySQL and MariaDB. Quoting it ensures proper creation and operation of the table when creating the table viamysqli.Fixes #9796
Checklist: