Skip to content

Add CNAME #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add CNAME #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ service('settings')->forget('App.siteName');

## Docs

Read the full documentation: https://codeigniter4.github.io/settings/
Read the full documentation: https://settings.codeigniter.com
Copy link
Contributor

@datamweb datamweb Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are going to use https://settings.codeigniter.com, it is better to use it in all cases. including file composer.js & mkdocs.yml and...

Copy link
Member Author

@michalsn michalsn Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO composer.json should link to the source code only.
As for MkDocs... do you mean instead of linking to codeigniter.com in extra.homepage?

Copy link
Contributor

@datamweb datamweb Dec 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO composer.json should link to the source code only.

Thanks, I didn't know that.

As for MkDocs... do you mean instead of linking to codeigniter.com in extra.homepage?

Sorry. No, it's fine now, I thought there was a link to the docs defined in MkDocs.


## Contributing

Expand Down
1 change: 1 addition & 0 deletions docs/CNAME
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
settings.codeigniter.com