Skip to content

Update README.md #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2021
Merged

Update README.md #25

merged 1 commit into from
Dec 17, 2021

Conversation

@galihlasahido
Copy link
Contributor

typo in some service name (setting, suppose to be settings) resulting Call to a member function get() on null

@galihlasahido
Update README.md
98a8c90 
typo in some service name (setting, suppose to be settings) resulting Call to a member function get() on null
MGatner
MGatner approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It is a little confusing since the helper function is singular, but the service and helper file are both plural.

@MGatner MGatner merged commit cf9ae1e into codeigniter4:develop Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@galihlasahido @MGatner