refactor: improve @return of setting()
#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Settings::set() returns void.
MGatner
requested changes
Apr 22, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
One optimization, rest looks good!
src/Config/Services.php
Outdated
Comment on lines
33
to
36
|
|
||
| /** @var SettingsConfig $config */ | ||
| $config = $config ?? config('Settings'); | ||
| $config ??= config('Settings'); | ||
|
|
||
| return new Settings($config); |
Member
There was a problem hiding this comment.
The only reason this was separate was for the inline type. If that isn't needed we don't need the intermediate variable.
return new Settings($config ?? config('Settings'));
MGatner
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.