test: add folders and move test files #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
requested changes
Jun 1, 2022
| $config = new Auth(); | ||
| $auth = new Authentication($config); | ||
| $auth->setProvider(model(UserModel::class)); // @phpstan-ignore-line | ||
| $auth->setProvider(\model(UserModel::class)); // @phpstan-ignore-line |
Member
There was a problem hiding this comment.
Our style guide decided against slashing root functions. Did you add these, or did they slip in via CS Fixer/Rector somehow?
Member
Author
There was a problem hiding this comment.
It seems PhpStorm did it when refactoring.
MGatner
requested changes
Jun 1, 2022
Member
MGatner
left a comment
MGatner
left a comment
There was a problem hiding this comment.
I'm good with the folder move but please revert the function slashing. If you have a compelling case for them we should discuss it for the style guide first.
MGatner
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many files in a folder.