Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Sep 20, 2022

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little "best practice" thrown in there, why not?

Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good explanation.
Thanks🥀

@kenjis kenjis merged commit 9b889b3 into codeigniter4:develop Sep 22, 2022
@kenjis kenjis deleted the docs-note-strong_password branch September 22, 2022 02:08
@kenjis
Copy link
Member Author

kenjis commented Sep 22, 2022

A little "best practice" thrown in there, why not?

What do you mean?
What is the best practice?

@MGatner
Copy link
Member

MGatner commented Sep 22, 2022

I meant your comments at the end:

But remember, it is not good practice to set passwords for other users.
This is because the password should be known only by that user.

Our docs carry quite a bit of "here is how you should use this" in addition to "here is how it works". Given the state of web security these days I think that is a good thing! People have sadly insufficient understanding of web app security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants