-
Notifications
You must be signed in to change notification settings - Fork 143
Fix comments for $groups in AuthGroups.php #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current comment content does not match what the code is doing. Please feel free to clean up or let me know any suggestions. Thank you!
|
Yes, the comment does not match at all. Good catch! |
Co-authored-by: kenjis <kenji.uui@gmail.com>
|
Please run 1) shield/src/Config/AuthGroups.php (no_trailing_whitespace_in_comment)
---------- begin diff ----------
--- /home/runner/work/shield/shield/src/Config/AuthGroups.php
+++ /home/runner/work/shield/shield/src/Config/AuthGroups.php
@@ -20,8 +20,8 @@
* --------------------------------------------------------------------
* Groups
* --------------------------------------------------------------------
- * The available groups in the system.
- * Where the key is the group name, and the values are an
+ * The available groups in the system.
+ * Where the key is the group name, and the values are an
* array of the group info.
* Whatever value you assign as the key, will be used to refer to the group when using functions such as:
* $user->addGroup('superadmin')
----------- end diff ----------- |
|
Hi, run the following commands, before running make sure the commit GPG sign settings are set to global. Composer cs-fix src/Config/AuthGroups.php
git add src/Config/AuthGroups.php
git commit -m 'style: run cs-fix'
git push origin patch-1 |
|
Please use |
|
@iamsyh are you able to get these changes fixed up? Would love to merge this. |
yes i will do it today. apologies for the delay, have been caught up in things |
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
|
Looks like one more CS Fixer issue. Your branch also has some merges in it - you can start over in a new PR and cherry-pick your changes, or we can just squash this once it is ready. |
The current comment content does not match what the code is doing. Please feel free to clean up or let me know any suggestions.
Thank you!