Skip to content

Conversation

@iamsyh
Copy link
Contributor

@iamsyh iamsyh commented Nov 3, 2022

The current comment content does not match what the code is doing. Please feel free to clean up or let me know any suggestions.

Thank you!

The current comment content does not match what the code is doing. Please feel free to clean up or let me know any suggestions.

Thank you!
@kenjis kenjis changed the title Update comments for groups in AuthGroups.php Fix comments for $groups in AuthGroups.php Nov 4, 2022
@kenjis
Copy link
Member

kenjis commented Nov 4, 2022

Yes, the comment does not match at all. Good catch!

Co-authored-by: kenjis <kenji.uui@gmail.com>
@kenjis
Copy link
Member

kenjis commented Nov 5, 2022

Please run composer cs-fix to fix the coding style.

   1) shield/src/Config/AuthGroups.php (no_trailing_whitespace_in_comment)
      ---------- begin diff ----------
--- /home/runner/work/shield/shield/src/Config/AuthGroups.php
+++ /home/runner/work/shield/shield/src/Config/AuthGroups.php
@@ -20,8 +20,8 @@
      * --------------------------------------------------------------------
      * Groups
      * --------------------------------------------------------------------
-     * The available groups in the system. 
-     * Where the key is the group name, and the values are an 
+     * The available groups in the system.
+     * Where the key is the group name, and the values are an
      * array of the group info.
      * Whatever value you assign as the key, will be used to refer to the group when using functions such as:
      *      $user->addGroup('superadmin')

      ----------- end diff -----------

@datamweb
Copy link
Collaborator

datamweb commented Nov 5, 2022

Hi, run the following commands, before running make sure the commit GPG sign settings are set to global.

Composer cs-fix src/Config/AuthGroups.php
git add src/Config/AuthGroups.php
git commit -m 'style: run cs-fix'
git push origin patch-1

@kenjis
Copy link
Member

kenjis commented Nov 5, 2022

Please use git rebase instead of git merge if you can.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

@datamweb datamweb added the waiting for info Issues or pull requests that need further clarification from the author label Nov 7, 2022
@lonnieezell
Copy link
Member

@iamsyh are you able to get these changes fixed up? Would love to merge this.

@iamsyh
Copy link
Contributor Author

iamsyh commented Nov 16, 2022

@iamsyh are you able to get these changes fixed up? Would love to merge this.

yes i will do it today. apologies for the delay, have been caught up in things

iamsyh and others added 3 commits November 16, 2022 05:28
@MGatner
Copy link
Member

MGatner commented Nov 16, 2022

Looks like one more CS Fixer issue. Your branch also has some merges in it - you can start over in a new PR and cherry-pick your changes, or we can just squash this once it is ready.

@MGatner MGatner merged commit bfbbd03 into codeigniter4:develop Nov 18, 2022
@iamsyh iamsyh deleted the patch-1 branch November 23, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting for info Issues or pull requests that need further clarification from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants