-
Notifications
You must be signed in to change notification settings - Fork 144
fix: shield:user create
with default group
#999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shield:user create
with default group
#999
Conversation
Two items. PRLintReloaded It requires configuration, which I do not have the necessary access to do, please do the necessary configuration. |
In the future I'd rather see all of the unrelated fixes in a separate PR. I know Rector was being a pain though. While I like the idea, I think in the situations I'd be using it from the command line I'd rather be able to define which role during the creation process, instead of being forced into the default and then having to go to the database to change it. What do you think about reading the available roles from the config file and presenting that as a required choice to the user? |
@datamweb it probably related with dependabot config, 0.18.x probably only call 0.18.y, while 0.19.a need to be triggerable on specific config. CodeIgniter4 repo seems auto-update it |
Good idea, I'd like to come back to these PR at another time. |
One can also make the |
I send PR #1001 for add Rules. |
Sorry - forgot to reply here earlier, but PRLintReloaded is installed and should be working now. |
Closed by #1162 |
Description
fix: #998
The user registration form sets the default group value for the user when a new user is registered. Although I don't consider this a bug, I prefer that this process be done for command
shield:user create
as well.Checklist: