Skip to content

Conversation

@Arhell
Copy link
Member

@Arhell Arhell commented Feb 12, 2022

No description provided.

@Arhell Arhell linked an issue Feb 12, 2022 that may be closed by this pull request
@Arhell Arhell requested review from a team and MGatner February 12, 2022 00:47
@coveralls
Copy link

coveralls commented Feb 12, 2022

Pull Request Test Coverage Report for Build 1835005965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.161%

Totals Coverage Status
Change from base Build 1827003506: 0.0%
Covered Lines: 246
Relevant Lines: 323

💛 - Coveralls

@MGatner
Copy link
Collaborator

MGatner commented Feb 12, 2022

I realize this is still in draft so you might already be working on this but: we should not make changes to third-party assets. Also, not sure how difficult this would be, but some links may not be valid as HTTPS and it would be good to confirm them before updating.

@Arhell Arhell marked this pull request as ready for review February 12, 2022 22:18
@Arhell
Copy link
Member Author

Arhell commented Feb 12, 2022

I realize this is still in draft so you might already be working on this but: we should not make changes to third-party assets. Also, not sure how difficult this would be, but some links may not be valid as HTTPS and it would be good to confirm them before updating.

Updated links, also checked

@Arhell Arhell requested a review from demyr17 February 16, 2022 01:05
Copy link
Collaborator

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Arhell Arhell merged commit 5103b17 into develop Feb 18, 2022
@Arhell Arhell deleted the upd branch February 18, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update links

4 participants