Skip to content

Fix Live View big file fetching #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benhatsor merged 2 commits into from
Aug 28, 2024
Merged

Fix Live View big file fetching #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2a1e42
Update live-view.js
benhatsor Aug 28, 2024
b15eba5
Update service-worker.js
benhatsor Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions live-view/live-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,9 +1062,10 @@ async function handleLiveViewRequest(requestPath) {


// if file is over 1MB
if (resp.errors && resp.errors.length > 0 && resp.errors[0].code === 'too_large') {
if ((resp.errors && resp.errors.length > 0 && resp.errors[0].code === 'too_large') ||
(resp.size && resp.size >= 1000000 && resp.content === '')) {

console.log('[Live view] File', fileName, 'over 1MB, fetching from blob API');
// console.log('[Live view] File', fileName, 'over 1MB, fetching from blob API');

// fetch file directory
const dirResp = await git.getItems(liveFileDir);
Expand Down
2 changes: 1 addition & 1 deletion service-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

// update worker name when updating cached files
const WORKER_NAME = 'codeit-worker-v770';
const WORKER_NAME = 'codeit-worker-v771';


self.importScripts('/worker/client-channel.js');
Expand Down